[Intel-wired-lan] [PATCH] intel-wired-lan: igc: set TP bit in ethtool_link_ksettings.supported field
Prasad Koya
prasad at arista.com
Sat Jun 3 06:05:47 UTC 2023
Hi Sasha
In our internal review, we found that igb and other vendors' drivers set
the TP (or other media) bit in the 'advertising' field as well. So I made
the and tested the change in 6.1.31 kernel. Will send that patch for
review.
Thank you.
On Fri, Jun 2, 2023 at 12:49 AM Prasad Koya <prasad at arista.com> wrote:
> Thanks for the quick review.
>
> Yes, we use ETHTOOL_GLINKSETTINGS ioctl to retrieve interface settings and
> expect to see one of TP or MII set in the 'supported' bitmask.
>
> I'll send out a new patch removing the if(). Would you accept the patch
> into your staging tree and later push it to the stable kernel branch? This
> is my first time sending to intel-wired-lan. Not sure how it works.
>
> Thank you.
>
> On Fri, Jun 2, 2023 at 12:34 AM Neftin, Sasha <sasha.neftin at intel.com>
> wrote:
>
>> On 6/1/2023 21:53, prasad at arista.com wrote:
>> > From: Prasad Koya <prasad at arista.com>
>> >
>> > if the physical media is twisted pair copper, set the TP bit in the
>> > 'supported' field
>> >
>> > Signed-off-by: Prasad Koya <prasad at arista.com>
>> > ---
>> > drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> > diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> > index 8cc077b712ad..7d197fa80d5d 100644
>> > --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> > +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> > @@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct
>> net_device *netdev,
>> > /* twisted pair */
>> > cmd->base.port = PORT_TP;
>> > cmd->base.phy_address = hw->phy.addr;
>> > + if (hw->phy.media_type == igc_media_type_copper)
>> Thank you Prasad. i225/6 parts supported only copper media type. We can
>> drop the "if" condition.
>> > + ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
>> Do you want to see: "Supported ports: [ TP ]"? That's right.
>> >
>> > /* advertising link modes */
>> > if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20230602/2175cfe9/attachment-0001.html>
More information about the Intel-wired-lan
mailing list