[Intel-wired-lan] [PATCH iwl-next v7 0/4] Support rx-fcs on/off for VFs
Ahmed Zaki
ahmed.zaki at intel.com
Wed Sep 6 19:57:00 UTC 2023
Allow the user to turn on/off the CRC/FCS stripping through ethtool. We
first add the CRC offload capability in the virtchannel, then the feature
is enabled in ice and iavf drivers.
We make sure that the netdev features are fixed such that CRC stripping
cannot be disabled if VLAN rx offload (VLAN strip) is enabled. Also, VLAN
stripping cannot be enabled unless CRC stripping is ON.
Testing was done using tcpdump to make sure that the CRC is included in
the frame after:
# ethtool -K <interface> rx-fcs on
and is not included when it is back "off". Also, ethtool should return an
error for the above command if "rx-vlan-offload" is already on and at least
one VLAN interface/filter exists on the VF.
---
v7: Paul Menzel's comments on v5 and v6:
Commit messages in cover letter, (1/4), (3/4) and (4/4)
Title of (3/4): ice: Check CRC strip requirement for VLA strip
Remove u16 stack variable in ice_vsi_is_rxq_crc_strip_dis() (3/4)
v6: Some code was mistakenly included in v5 (4/4), sorry for spamming.
v5: Remove extra space in ice_for_each_alloc_rxq() (3/4)
v4: Use ice_for_each_alloc_rxq in ice_vsi_is_rxq_crc_strip_dis() (3/4)
v3: Fix Tony's comments in ice_vf_init_vlan_stripping() (3/4)
v2: Move patch "ice: Fix VLAN and CRC strip co-existence" from 4/4 to 3/4
Other minor fixes from Tony for the same patch
Haiyue Wang (2):
ice: Support FCS/CRC strip disable for VF
ice: Check CRC strip requirement for VLAN strip
Norbert Zulinski (1):
iavf: Add ability to turn off CRC stripping for VF
Paul M Stillwell Jr (1):
virtchnl: Add CRC stripping capability
drivers/net/ethernet/intel/iavf/iavf.h | 2 +
drivers/net/ethernet/intel/iavf/iavf_main.c | 59 +++++++++++++++-
.../net/ethernet/intel/iavf/iavf_virtchnl.c | 4 ++
drivers/net/ethernet/intel/ice/ice_vf_lib.h | 3 +
drivers/net/ethernet/intel/ice/ice_virtchnl.c | 69 +++++++++++++++++--
include/linux/avf/virtchnl.h | 11 ++-
6 files changed, 141 insertions(+), 7 deletions(-)
--
2.34.1
More information about the Intel-wired-lan
mailing list