[Intel-wired-lan] [PATCH iwl-net v1] ice: don't stop netdev tx queues when setting up XSK socket
Kamil Maziarz
kamil.maziarz at intel.com
Fri Sep 8 11:31:01 UTC 2023
Avoid stopping netdev tx queues during XSK setup by removing
netif_tx_stop_queue() and netif_tx_start_queue(). These changes
prevent unnecessary stopping and starting of netdev transmit queues
during the setup of XDP socket. Without this change, after stopping
the XDP traffic flow tracker and then stopping the XDP prog - NETDEV
WATCHDOG transmit queue timed out appears.
Signed-off-by: Kamil Maziarz <kamil.maziarz at intel.com>
Signed-off-by: Piotr Raczynski <piotr.raczynski at intel.com>
---
drivers/net/ethernet/intel/ice/ice_xsk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c
index a7fe2b4ce655..cd56ceae8aef 100644
--- a/drivers/net/ethernet/intel/ice/ice_xsk.c
+++ b/drivers/net/ethernet/intel/ice/ice_xsk.c
@@ -179,7 +179,6 @@ static int ice_qp_dis(struct ice_vsi *vsi, u16 q_idx)
return -EBUSY;
usleep_range(1000, 2000);
}
- netif_tx_stop_queue(netdev_get_tx_queue(vsi->netdev, q_idx));
ice_fill_txq_meta(vsi, tx_ring, &txq_meta);
err = ice_vsi_stop_tx_ring(vsi, ICE_NO_RESET, 0, tx_ring, &txq_meta);
@@ -268,7 +267,6 @@ static int ice_qp_ena(struct ice_vsi *vsi, u16 q_idx)
ice_qvec_toggle_napi(vsi, q_vector, true);
ice_qvec_ena_irq(vsi, q_vector);
- netif_tx_start_queue(netdev_get_tx_queue(vsi->netdev, q_idx));
free_buf:
kfree(qg_buf);
return err;
--
2.31.1
More information about the Intel-wired-lan
mailing list