[Intel-wired-lan] [PATCH iwl-next v1] i40e: Refactor parameters name in i40e_print_input_set

[Tony Nguyen]

On 9/7/2023 3:00 AM, Kamil Maziarz wrote:
> From: Grzegorz Szczurek <grzegorzx.szczurek at intel.com
> 
> Change function parameter old/new in i40e_print_input_set.
> This change improves readability.

Carrying over comment that Olek made:

It makes no sense to send such patches as standalone. It should be 
either included in a bigger series or just don't bother. They just 
create more load on reviewers and maintainers with no positive output.

> Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek at intel.com>
> Co-developed-by: Antoni Czarnecki <antonix.czarnecki at intel.com>


For future reference, matching signoff must be included and directly 
follow co-developed.

> Signed-off-by: Kamil Maziarz <kamil.maziarz at intel.com>
> ---
>   .../net/ethernet/intel/i40e/i40e_ethtool.c    | 35 ++++++++++---------
>   1 file changed, 18 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index bd1321bf7e26..c86ad944b59d 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -4190,49 +4190,50 @@ static u64 i40e_pit_index_to_mask(int pit_index)
>   /**
>    * i40e_print_input_set - Show changes between two input sets
>    * @vsi: the vsi being configured
> - * @old: the old input set
> - * @new: the new input set
> + * @old_input: the old input set
> + * @new_input: the new input set
>    *
>    * Print the difference between old and new input sets by showing which series
>    * of words are toggled on or off. Only displays the bits we actually support
>    * changing.
>    **/
> -static void i40e_print_input_set(struct i40e_vsi *vsi, u64 old, u64 new)
> +static void i40e_print_input_set(struct i40e_vsi *vsi,
> +				 u64 old_input, u64 new_input)
>   {
>   	struct i40e_pf *pf = vsi->back;
>   	bool old_value, new_value;
>   	int i;
>   
> -	old_value = !!(old & I40E_L3_SRC_MASK);
> -	new_value = !!(new & I40E_L3_SRC_MASK);
> +	old_value = !!(old_input & I40E_L3_SRC_MASK);
> +	new_value = !!(new_input & I40E_L3_SRC_MASK);
>   	if (old_value != new_value)
>   		netif_info(pf, drv, vsi->netdev, "L3 source address: %s -> %s\n",
>   			   old_value ? "ON" : "OFF",
>   			   new_value ? "ON" : "OFF");
>   
> -	old_value = !!(old & I40E_L3_DST_MASK);
> -	new_value = !!(new & I40E_L3_DST_MASK);
> +	old_value = !!(old_input & I40E_L3_DST_MASK);
> +	new_value = !!(new_input & I40E_L3_DST_MASK);
>   	if (old_value != new_value)
>   		netif_info(pf, drv, vsi->netdev, "L3 destination address: %s -> %s\n",
>   			   old_value ? "ON" : "OFF",
>   			   new_value ? "ON" : "OFF");
>   
> -	old_value = !!(old & I40E_L4_SRC_MASK);
> -	new_value = !!(new & I40E_L4_SRC_MASK);
> +	old_value = !!(old_input & I40E_L4_SRC_MASK);
> +	new_value = !!(new_input & I40E_L4_SRC_MASK);
>   	if (old_value != new_value)
>   		netif_info(pf, drv, vsi->netdev, "L4 source port: %s -> %s\n",
>   			   old_value ? "ON" : "OFF",
>   			   new_value ? "ON" : "OFF");
>   
> -	old_value = !!(old & I40E_L4_DST_MASK);
> -	new_value = !!(new & I40E_L4_DST_MASK);
> +	old_value = !!(old_input & I40E_L4_DST_MASK);
> +	new_value = !!(new_input & I40E_L4_DST_MASK);
>   	if (old_value != new_value)
>   		netif_info(pf, drv, vsi->netdev, "L4 destination port: %s -> %s\n",
>   			   old_value ? "ON" : "OFF",
>   			   new_value ? "ON" : "OFF");
>   
> -	old_value = !!(old & I40E_VERIFY_TAG_MASK);
> -	new_value = !!(new & I40E_VERIFY_TAG_MASK);
> +	old_value = !!(old_input & I40E_VERIFY_TAG_MASK);
> +	new_value = !!(new_input & I40E_VERIFY_TAG_MASK);
>   	if (old_value != new_value)
>   		netif_info(pf, drv, vsi->netdev, "SCTP verification tag: %s -> %s\n",
>   			   old_value ? "ON" : "OFF",
> @@ -4242,8 +4243,8 @@ static void i40e_print_input_set(struct i40e_vsi *vsi, u64 old, u64 new)
>   	for (i = 0; i < I40E_FLEX_INDEX_ENTRIES; i++) {
>   		u64 flex_mask = i40e_pit_index_to_mask(i);
>   
> -		old_value = !!(old & flex_mask);
> -		new_value = !!(new & flex_mask);
> +		old_value = !!(old_input & flex_mask);
> +		new_value = !!(new_input & flex_mask);
>   		if (old_value != new_value)
>   			netif_info(pf, drv, vsi->netdev, "FLEX index %d: %s -> %s\n",
>   				   i,
> @@ -4252,9 +4253,9 @@ static void i40e_print_input_set(struct i40e_vsi *vsi, u64 old, u64 new)
>   	}
>   
>   	netif_info(pf, drv, vsi->netdev, "  Current input set: %0llx\n",
> -		   old);
> +		   old_input);
>   	netif_info(pf, drv, vsi->netdev, "Requested input set: %0llx\n",
> -		   new);
> +		   new_input);
>   }
>   
>   /**