[Intel-wired-lan] [ANN] Upstreaming Process Change - Mandatory "reviewed-by" Tag
Rucinska, Monika
monika.rucinska at intel.com
Wed Sep 27 15:22:31 UTC 2023
Dear e1000 and IWL contributors,
We are implementing a crucial process change to enhance the quality
and efficiency of our upstream development and upstreaming efforts.
Effective immediately, every INTEL/NCIS patch posted to IWL must have
at least one "Reviewed-by" tag, those are provided during e1000 review
process. Any exceptions to that process must be agreed upon. By adding
the "reviewed-by" tag, we can establish a clear indication that a patch
has undergone careful scrutiny and has received approval from a reviewer.
Key Rules:
1. Mandatory "reviewed-by" Tag: Every patch submitted to e1000
must have at least one "reviewed-by" tag from a reviewer before it is
sent to IWL. This tag serves as a sign of endorsement and validates
the quality of the patch.
2. Completion within 48 Hours: The review
process should be completed within 48 hours after the patch appears on
e1000, except for large series that may require more time. We encourage
reviewers to provide timely feedback, ensuring a smooth and efficient
upstreaming process.
3. Continued Tagging in Subsequent Patch Series:
The "reviewed-by" tag should continue to be added to subsequent patch
series for IWL. This ensures that each iteration of the patch receives
the necessary reviews, even if modifications have been made.
These changes aim to streamline the upstreaming process, improve code
quality, and encourage collaboration among contributors. Please ensure
compliance with these new guidelines.
If you have any questions or need further clarification regarding this
process change, please feel free to reach out to me or any of upstreaming
contact points. Thank you for your understanding and commitment
to maintaining the highest standards in our upstreaming process.
For more detailed information please follow the link to the Wiki [1]
or to presentation [2].
[1]
https://wiki.ith.intel.com/pages/viewpage.action?spaceKey=LADSW&title=How+to+upstream+a+patch
[2]
https://intel-my.sharepoint.com/:p:/p/monika_rucinska/EQs_jci29JlKvDIW1Yb6go0BBNnUf3A_IrVFBfn63ltqmw?e=NqRqce
Best regards,
Monika Rucińska
More information about the Intel-wired-lan
mailing list