[Intel-wired-lan] [PATCH iwl-next] i40e: Use correct buffer size
Simon Horman
horms at kernel.org
Wed Nov 15 09:21:23 UTC 2023
On Wed, Nov 15, 2023 at 11:14:44AM +0800, Kunwu Chan wrote:
> The size of "i40e_dbg_command_buf" is 256, the size of "name"
> depends on "IFNAMSIZ", plus a null character and format size,
> the total size is more than 256, fix it.
>
> Signed-off-by: Kunwu Chan <chentao at kylinos.cn>
> Suggested-by: Simon Horman <horms at kernel.org>
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the update.
There is no need to repost because of this, but in future please keep in
mind that revised patches should:
1. have a revision number, e.g. v2
Subject [PATCH v2 iwl-next] ...
2. Have some of revision information below the scissors (---)
v2
- Updated size calculation to use IFNAMSIZ and izeof(i40e_dbg_command_buf)
3. Be a new thread, as opposed to a reply to an existing thread.
Link: https://docs.kernel.org/process/maintainer-netdev.html#changes-requested
The above notwithstanding, this patch looks good to me.
Reviewed-by: Simon Horman <horms at kernel.org>
More information about the Intel-wired-lan
mailing list