[Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

Nick Desaulniers ndesaulniers at google.com
Mon Dec 18 19:08:38 UTC 2023


On Mon, Dec 18, 2023 at 11:00 AM Nathan Chancellor <nathan at kernel.org> wrote:
>
> On Mon, Dec 18, 2023 at 08:32:28AM -0800, Nick Desaulniers wrote:
> > (Is -Wcomma enabled by -Wall?)
>
> No and last time that I looked into enabling it, there were a lot of
> instances in the kernel:
>
> https://lore.kernel.org/20230630192825.GA2745548@dev-arch.thelio-3990X/
>
> It is still probably worth pursuing at some point but that is a lot of
> instances to clean up (along with potentially having a decent amount of
> pushback depending on the changes necessary to eliminate all instances).

Filed this todo:
https://github.com/ClangBuiltLinux/linux/issues/1968
I'd be happy if Simon keeps poking at getting that warning enabled.
-- 
Thanks,
~Nick Desaulniers


More information about the Intel-wired-lan mailing list