[Intel-wired-lan] [PATCH v4 iwl-next 5/6] ice: factor out ice_ptp_rebuild_owner()

[Keller, Jacob E]

> -----Original Message-----
> From: Sokolowski, Jan <jan.sokolowski at intel.com>
> Sent: Thursday, December 21, 2023 2:20 AM
> To: Kolacinski, Karol <karol.kolacinski at intel.com>; intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org; Nguyen, Anthony L <anthony.l.nguyen at intel.com>;
> Brandeburg, Jesse <jesse.brandeburg at intel.com>; Keller, Jacob E
> <jacob.e.keller at intel.com>; Kolacinski, Karol <karol.kolacinski at intel.com>
> Subject: RE: [PATCH v4 iwl-next 5/6] ice: factor out ice_ptp_rebuild_owner()
> 
> >From: Jacob Keller <jacob.e.keller at intel.com>
> >
> >The ice_ptp_reset() function uses a goto to skip past clock owner
> >operations if performing a PF reset or if the device is not the clock
> >owner. This is a bit confusing. Factor this out into
> >ice_ptp_rebuild_owner() instead.
> 
> To me at least, the wording of the title (Factor out) is kinda
> confusing when compared to the message itself, as if you were going
> to remove the ice_ptp_rebuild_owner anyway.
> 
> Other than that, LGTM.
> 

Ya, the idea is to split the functionality into a separate function.