[Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

Pucha, HimasekharX Reddy himasekharx.reddy.pucha at intel.com
Wed Dec 27 14:13:05 UTC 2023


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Simon Horman
> Sent: Sunday, December 17, 2023 3:15 PM
> To: Brandeburg, Jesse <jesse.brandeburg at intel.com>; Nguyen, Anthony L <anthony.l.nguyen at intel.com>
> Cc: netdev at vger.kernel.org; llvm at lists.linux.dev; Nick Desaulniers <ndesaulniers at google.com>; Nathan Chancellor <nathan at kernel.org>; Eric Dumazet <edumazet at google.com>; intel-wired-lan at lists.osuosl.org; Bill Wendling <morbo at google.com>; Justin Stitt <justinstitt at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; David S. Miller <davem at davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator
>
> Although it does not seem to have any untoward side-effects,
> the use of ';' to separate to assignments seems more appropriate than ','.
>
> Flagged by clang-17 -Wcomma
>
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms at kernel.org>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha at intel.com> (A Contingent worker at Intel)



More information about the Intel-wired-lan mailing list