[Intel-wired-lan] [PATCH v6 iwl-next 3/7] ice: rename verify_cached to has_ready_bitmap

Tony Nguyen anthony.l.nguyen at intel.com
Mon Jan 22 21:39:09 UTC 2024


On 1/18/2024 9:45 AM, Karol Kolacinski wrote:
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> The tx->verify_cached flag is used to inform the Tx timestamp tracking
> code whether it needs to verify the cached Tx timestamp value against
> a previous captured value. This is necessary on E810 hardware which does
> not have a Tx timestamp ready bitmap.
> 
> In addition, we currently rely on the fact that the
> ice_get_phy_tx_tstamp_ready() function returns all 1s for E810 hardware.
> Instead of introducing a brand new flag, rename and verify_cached to
> has_ready_bitmap,

Looks like you missed one...

drivers/net/ethernet/intel/ice/ice_ptp.c: In function 
‘ice_ptp_process_tx_tstamp’:
drivers/net/ethernet/intel/ice/ice_ptp.c:754:35: error: ‘struct 
ice_ptp_tx’ has no member named ‘verify_cached’
   754 |                 if (!drop_ts && tx->verify_cached &&

Thanks,
Tony

> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski at intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller at intel.com>



More information about the Intel-wired-lan mailing list