[Intel-wired-lan] [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int

Jagielski, Jedrzej jedrzej.jagielski at intel.com
Thu Jan 25 10:16:43 UTC 2024


From: Nguyen, Anthony L <anthony.l.nguyen at intel.com> 
Sent: Monday, January 22, 2024 10:19 PM

>On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote:
>> Currently big amount of the functions returning standard error codes
>> are of type s32. Convert them to regular ints as typdefs here are not
>> necessary to return standard error codes.
>> 
>> Suggested-by: Jacob Keller <jacob.e.keller at intel.com>
>> Reviewed-by: Jacob Keller <jacob.e.keller at intel.com>
>> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski at intel.com>
>
>There's various checkpatch issues being reported:
>
>CHECK: Alignment should match open parenthesis
>ERROR: space prohibited before that ',' (ctx:WxW)
>WARNING: please, no space before tabs
>
>Seems like a number of these can be remedied.

Can they be addressed in the separate, already existing clean up patch.
Or obligatorily they must be remedied in this patch?

Thanks

>
>Thanks,
>Tony


More information about the Intel-wired-lan mailing list