[Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may be used uninitialized in this function warning

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Paul Menzel <pmenzel at molgen.mpg.de>
> Sent: Wednesday, March 13, 2024 11:58 AM
> To: Loktionov, Aleksandr <aleksandr.loktionov at intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen at intel.com>; netdev at vger.kernel.org; Kitszel,
> Przemyslaw <przemyslaw.kitszel at intel.com>; Kubalewski, Arkadiusz
> <arkadiusz.kubalewski at intel.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] i40e: fix vf may
> be used uninitialized in this function warning
> 
> Dear Aleksandr,
> 
> 
> Am 13.03.24 um 10:56 schrieb Aleksandr Loktionov:
> > To fix the regression introduced by commit 52424f974bc5, which
> causes
> > servers hang in very hard to reproduce conditions with resets
> races.
> > Using two sources for the information is the root cause.
> > In this function before the fix bumping v didn't mean bumping vf
> > pointer. But the code used this variables interchangeably, so
> staled
> > vf could point to different/not intended vf.
> >
> > Remove redundant "v" variable and iterate via single VF pointer
> across
> > whole function instead to guarantee VF pointer validity.
> >
> > Fixes: 52424f974bc5 ("i40e: Fix VF hang when reset is triggered
> on
> > another VF")
> > Signed-off-by: Aleksandr Loktionov
> <aleksandr.loktionov at intel.com>
> > Reviewed-by: Arkadiusz Kubalewski
> <arkadiusz.kubalewski at intel.com>
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel at intel.com>
> > ---
> > v1 -> v2: commit message change
> 
> Thank you very much. No need to resend, but I find it also always
> useful to have the exact warning pasted in the commit message.
> 
The warning is exactly "vf may be used uninitialized in this function"  it's already in the title. What you suggest me to do?
Thank you

> […]
> 
> > ---
> >   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 34 +++++++++---
> -------
> >   1 file changed, 16 insertions(+), 18 deletions(-)
> 
> Reviewed-by: Paul Menzel <pmenzel at molgen.mpg.de>
> 
> 
> Kind regards,
> 
> Paul