[Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
Sebastian Andrzej Siewior
bigeasy at linutronix.de
Thu Mar 14 10:35:45 UTC 2024
On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote:
> On 3/13/24 14:03, Kurt Kanzenbach wrote:
> > The initial igc Tx timestamping implementation used only one register for
> > retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> > multiple in-flight TX timestamps") added support for utilizing all four of
> > them e.g., for multiple domain support. Remove the stale comment/FIXME.
> >
> > Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
>
> I would remove fixes tag (but keep the mention in commit msg).
> And I would also target it to iwl-next when the window will open.
>
> Rationale: it's really not a fix.
It is a fix as it removes something that is not accurate. But it only
changes a comment so it has not outcome in the binary. I think what you
mean is that you wish that it will not be backported stable. Still
people reading the code of a v6.6 kernel might get confused.
Sebastian
More information about the Intel-wired-lan
mailing list