[Intel-wired-lan] [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code

[Rout, ChandanX]

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, July 24, 2024 10:19 PM
>To: intel-wired-lan at lists.osuosl.org
>Cc: Drewek, Wojciech <wojciech.drewek at intel.com>; Fijalkowski, Maciej
><maciej.fijalkowski at intel.com>; Jesper Dangaard Brouer <hawk at kernel.org>;
>Daniel Borkmann <daniel at iogearbox.net>; Zaremba, Larysa
><larysa.zaremba at intel.com>; netdev at vger.kernel.org; John Fastabend
><john.fastabend at gmail.com>; Alexei Starovoitov <ast at kernel.org>; linux-
>kernel at vger.kernel.org; Eric Dumazet <edumazet at google.com>; Kubiak,
>Michal <michal.kubiak at intel.com>; Nguyen, Anthony L
><anthony.l.nguyen at intel.com>; Nambiar, Amritha
><amritha.nambiar at intel.com>; Keller, Jacob E <jacob.e.keller at intel.com>;
>Jakub Kicinski <kuba at kernel.org>; bpf at vger.kernel.org; Paolo Abeni
><pabeni at redhat.com>; David S. Miller <davem at davemloft.net>; Karlsson,
>Magnus <magnus.karlsson at intel.com>
>Subject: [Intel-wired-lan] [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY
>locking from AF_XDP code
>
>Locking used in ice_qp_ena() and ice_qp_dis() does pretty much nothing,
>because ICE_CFG_BUSY is a state flag that is supposed to be set in a PF state,
>not VSI one. Therefore it does not protect the queue pair from e.g. reset.
>
>Despite being useless, it still can deadlock the unfortunate functions that have
>fell into the same ICE_CFG_BUSY-VSI trap. This happens if ice_qp_ena returns
>an error.
>
>Remove ICE_CFG_BUSY locking from ice_qp_dis() and ice_qp_ena().
>
>Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
>Reviewed-by: Wojciech Drewek <wojciech.drewek at intel.com>
>Signed-off-by: Larysa Zaremba <larysa.zaremba at intel.com>
>---
> drivers/net/ethernet/intel/ice/ice_xsk.c | 9 ---------
> 1 file changed, 9 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout at intel.com> (A Contingent Worker at Intel)