[Intel-wired-lan] [PATCH iwl-next 3/7] ice: do not clutter debug logs with unused data

[Pucha, HimasekharX Reddy]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Jacob Keller
> Sent: Wednesday, August 7, 2024 2:16 AM
> To: Nguyen, Anthony L <anthony.l.nguyen at intel.com>; Intel Wired LAN <intel-wired-lan at lists.osuosl.org>; "netdev netdev"@vger.kernel.org
> Cc: Temerkhanov, Sergey <sergey.temerkhanov at intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel at intel.com>; Kolacinski, Karol <karol.kolacinski at intel.com>; Wierzbicki, Jacek <jacek.wierzbicki at intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next 3/7] ice: do not clutter debug logs with unused data
>
> From: Bruce Allan <bruce.w.allan at intel.com>
>
> Currently, debug logs are unnecessarily cluttered with the contents of command data buffers even if the receiver of that command (i.e. FW or MBX) are not told to read the buffer.  Change to only log command data buffers when the RD flag (indicates receiver needs to read > the buffer) is set.
> Continue to log response data buffer when the returned datalen is non-zero.
>
> Also, rename a local variable to reflect what is in the hardware specification and how it is used elsewhere in the code, use local variables instead of duplicating endian conversions unnecessarily and remove an unnecessary assignment.
>
> Signed-off-by: Bruce Allan <bruce.w.allan at intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_adminq_cmd.h |  4 ++++
>  drivers/net/ethernet/intel/ice/ice_controlq.c   | 21 ++++++++++++---------
>  2 files changed, 16 insertions(+), 9 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha at intel.com> (A Contingent worker at Intel)