[Intel-wired-lan] [PATCH iwl-next 2/7] ice: improve debug print for control queue messages

[Pucha, HimasekharX Reddy]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Jacob Keller
> Sent: Wednesday, August 7, 2024 2:16 AM
> To: Nguyen, Anthony L <anthony.l.nguyen at intel.com>; Intel Wired LAN <intel-wired-lan at lists.osuosl.org>; "netdev netdev"@vger.kernel.org
> Cc: Temerkhanov, Sergey <sergey.temerkhanov at intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel at intel.com>; Kolacinski, Karol <karol.kolacinski at intel.com>; Wierzbicki, Jacek <jacek.wierzbicki at intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next 2/7] ice: improve debug print for control queue messages
>
> The ice_debug_cq function is called to print debug data for a control queue descriptor in multiple places. This includes both before we send a message on a transmit queue, after the writeback completion of a message on the transmit queue, and when we receive a message > on a receive queue.
>
> This function does not include data about *which* control queue the message is on, nor whether it was what we sent to the queue or what we received from the queue.
>
> Modify ice_debug_cq to take two extra parameters, a pointer to the control queue and a boolean indicating if this was a response or a command. Improve the debug messages by replacing "CQ CMD" with a string indicating which specific control queue (based on cq->qtype) > and whether this was a command sent by the PF or a response from the queue.
>
> This helps make the log output easier to understand and consume when debugging.
>
> Signed-off-by: Jacob Keller <jacob.e.keller at intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel at intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_controlq.c | 36 +++++++++++++++++++++++----
>  1 file changed, 31 insertions(+), 5 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha at intel.com> (A Contingent worker at Intel)