[Intel-wired-lan] [PATCH iwl-net] ice: Fix lldp packets dropping after changing the number of channels

Pucha, HimasekharX Reddy himasekharx.reddy.pucha at intel.com
Thu Aug 29 14:25:36 UTC 2024


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Martyna Szapar-Mudlaw
> Sent: Wednesday, June 26, 2024 3:14 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw at linux.intel.com>; Matěj Grégr <mgregr at netx.as>; Kitszel, Przemyslaw <przemyslaw.kitszel at intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix lldp packets dropping after changing the number of channels
>
> After vsi setup refactor commit 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") ice_cfg_sw_lldp function which removes rx rule directing LLDP packets to vsi is moved from ice_vsi_release to ice_vsi_decfg function. ice_vsi_decfg is used in more cases than just in vsi_release resulting in unnecessary removal of rx lldp packets handling switch rule. This leads to lldp packets being dropped after a change number of channels via ethtool.
> This patch moves ice_cfg_sw_lldp function that removes rx lldp sw rule back to ice_vsi_relese function.
>
> Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
> Reported-by: Matěj Grégr <mgregr at netx.as>
> Closes: https://lore.kernel.org/intel-wired-lan/1be45a76-90af-4813-824f-8398b69745a9@netx.as/T/#u
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel at intel.com>
> Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw at linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha at intel.com> (A Contingent worker at Intel)




More information about the Intel-wired-lan mailing list