[Intel-wired-lan] [PATCH linux-next] ice: use string choice helpers

[Przemek Kitszel]

On 10/29/24 17:37, R Sundar wrote:
> On 28/10/24 15:24, Przemek Kitszel wrote:
>> On 10/27/24 15:19, R Sundar wrote:
>>> Use string choice helpers for better readability.

>>>             bwm_lf.plllock_true_lock_cri ? "locked" : "unlocked");
>>
>> perhaps locked/unlocked could be added into string_choices.h
>>
> 
> Sure, Can I add locked/unlocked changes in linux-next repository and use 
> suggested-by Tag?

sure, that's way to go
but please first check if there are any other users (despite this
driver)

> 
> 
>>> @@ -471,7 +471,7 @@ static int ice_cfg_cgu_pll_e82x(struct ice_hw *hw,
>>>       /* Log the current clock configuration */
>>>       ice_debug(hw, ICE_DBG_PTP, "New CGU configuration -- %s, 
>>> clk_src %s, clk_freq %s, PLL %s\n",
>>> -          dw24.ts_pll_enable ? "enabled" : "disabled",
>>> +          str_enabled_disabled(dw24.ts_pll_enable),
>>>             ice_clk_src_str(dw24.time_ref_sel),
>>>             ice_clk_freq_str(dw9.time_ref_freq_sel),
>>>             bwm_lf.plllock_true_lock_cri ? "locked" : "unlocked");
>>> @@ -548,7 +548,7 @@ static int ice_cfg_cgu_pll_e825c(struct ice_hw *hw,
>>>       /* Log the current clock configuration */
>>>       ice_debug(hw, ICE_DBG_PTP, "Current CGU configuration -- %s, 
>>> clk_src %s, clk_freq %s, PLL %s\n",
>>> -          dw24.ts_pll_enable ? "enabled" : "disabled",
>>> +          str_enabled_disabled(dw24.ts_pll_enable),
>>>             ice_clk_src_str(dw23.time_ref_sel),
>>>             ice_clk_freq_str(dw9.time_ref_freq_sel),
>>>             ro_lock.plllock_true_lock_cri ? "locked" : "unlocked");
>>> @@ -653,7 +653,7 @@ static int ice_cfg_cgu_pll_e825c(struct ice_hw *hw,
>>>       /* Log the current clock configuration */
>>>       ice_debug(hw, ICE_DBG_PTP, "New CGU configuration -- %s, 
>>> clk_src %s, clk_freq %s, PLL %s\n",
>>> -          dw24.ts_pll_enable ? "enabled" : "disabled",
>>> +          str_enabled_disabled(dw24.ts_pll_enable),
>>>             ice_clk_src_str(dw23.time_ref_sel),
>>>             ice_clk_freq_str(dw9.time_ref_freq_sel),
>>>             ro_lock.plllock_true_lock_cri ? "locked" : "unlocked");
>>
>