[Intel-wired-lan] Small Integers: Big Penalty (was: [iwl-next v6 2/9] ice: devlink PF MSI-X max and min parameter)

[Paul Menzel]

Dear David, dear Michal,


Am 04.11.24 um 09:51 schrieb David Laight:
> From: Michal Swiatkowski
>> Sent: 04 November 2024 07:03
> ...
>>> The type of the devlink parameters msix_vec_per_pf_{min,max} is
>>> specified as u32, so you must use value.vu32 everywhere you work with
>>> them, not vu16.
>>>
>>
>> I will change it.
> 
> You also need a pretty good reason to use u16 anywhere at all.
> Just because the domain of the value is small doesn't mean the
> best type isn't [unsigned] int.
> 
> Any arithmetic (particularly on non x86) is likely to increase
> the code size above any perceived data saving.

In 2012 Scott Duplichan wrote *Small Integers: Big Penalty* [1]. Of 
course you always should measure yourself.


Kind regards,

Paul


[1]: https://notabs.org/coding/smallIntsBigPenalty.htm