[Intel-wired-lan] [PATCH iwl-net] ice: Fix VLAN pruning in switchdev mode

Buvaneswaran, Sujai sujai.buvaneswaran at intel.com
Fri Nov 22 13:17:18 UTC 2024


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Marcin Szycik
> Sent: Tuesday, November 5, 2024 12:19 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org; Marcin Szycik <marcin.szycik at linux.intel.com>;
> Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix VLAN pruning in switchdev
> mode
> 
> In switchdev mode the uplink VSI should receive all unmatched packets,
> including VLANs. Therefore, VLAN pruning should be disabled if uplink is in
> switchdev mode. It is already being done in ice_eswitch_setup_env(),
> however the addition of ice_up() in commit 44ba608db509 ("ice: do
> switchdev slow-path Rx using PF VSI") caused VLAN pruning to be re-enabled
> after disabling it.
> 
> Add a check to ice_set_vlan_filtering_features() to ensure VLAN filtering will
> not be enabled if uplink is in switchdev mode. Note that
> ice_is_eswitch_mode_switchdev() is being used instead of
> ice_is_switchdev_running(), as the latter would only return true after the
> whole switchdev setup completes.
> 
> Fixes: 44ba608db509 ("ice: do switchdev slow-path Rx using PF VSI")
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> Signed-off-by: Marcin Szycik <marcin.szycik at linux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Tested-by: Singh, PriyaX <priyax.singh at intel.com>


More information about the Intel-wired-lan mailing list