[Intel-wired-lan] [PATCH iwl-next v2 1/3] ice: remove SW side band access workaround for E825

[Nitka, Grzegorz]

> -----Original Message-----
> From: Simon Horman <horms at kernel.org>
> Sent: Monday, March 17, 2025 5:36 PM
> To: Nitka, Grzegorz <grzegorz.nitka at intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; Kolacinski,
> Karol <karol.kolacinski at intel.com>; Michal Swiatkowski
> <michal.swiatkowski at linux.intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel at intel.com>
> Subject: Re: [PATCH iwl-next v2 1/3] ice: remove SW side band access
> workaround for E825
> 
> On Mon, Mar 10, 2025 at 01:24:37PM +0100, Grzegorz Nitka wrote:
> > From: Karol Kolacinski <karol.kolacinski at intel.com>
> >
> > Due to the bug in FW/NVM autoload mechanism (wrong default
> > SB_REM_DEV_CTL register settings), the access to peer PHY and CGU
> > clients was disabled by default.
> >
> > As the workaround solution, the register value was overwritten by the
> > driver at the probe or reset handling.
> > Remove workaround as it's not needed anymore. The fix in autoload
> > procedure has been provided with NVM 3.80 version.
> 
> Hi Grzegorz,
> 
> As per my belated comment on v2 [*], I think it would be worth adding
> a brief comment here regarding this not being expected to cause
> a regression in HW+FW seen in the wild.
> 
> [*] https://lore.kernel.org/netdev/20250317163359.GC688833@kernel.org/
> 

Thanks Simon for your feedback.
Sure, I'll address it in next version.

Kind Regards

Grzegorz

> >
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel at intel.com>
> > Signed-off-by: Karol Kolacinski <karol.kolacinski at intel.com>
> > Signed-off-by: Grzegorz Nitka <grzegorz.nitka at intel.com>
> 
> ...