[Intel-wired-lan] [PATCH iwl-net v1] idpf: fix potential memory leak on kcalloc() failure
Tony Nguyen
anthony.l.nguyen at intel.com
Thu Apr 10 22:04:16 UTC 2025
On 4/7/2025 3:43 AM, Simon Horman wrote:
> On Fri, Apr 04, 2025 at 12:54:21PM +0200, Michal Swiatkowski wrote:
>> In case of failing on rss_data->rss_key allocation the function is
>> freeing vport without freeing earlier allocated q_vector_idxs. Fix it.
>>
>> Move from freeing in error branch to goto scheme.
>>
>> Fixes: 95af467d9a4e ("idpf: configure resources for RX queues")
>
> Hi Michal,
>
> WRT leaking q_vector_indxs, that allocation is not present at
> the commit cited above, so I think the correct Fixes tag for
> that problem is the following, where that allocation was added:
>
> Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
Patch applied. I do agree with Simon's assessment so plan to use this fixes.
Thanks,
Tony
More information about the Intel-wired-lan
mailing list