[Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler
kernel test robot
lkp at intel.com
Mon May 5 07:52:12 UTC 2025
Hi Sebastian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-next-queue/dev-queue]
[also build test WARNING on tnguy-net-queue/dev-queue linus/master v6.15-rc5 next-20250502]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sebastian-Andrzej-Siewior/igb-Request-igb_msix_other-as-a-threaded-interrupt-handler/20250430-225615
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git dev-queue
patch link: https://lore.kernel.org/r/20250430144452.8zcAZc29%40linutronix.de
patch subject: [Intel-wired-lan] [PATCH] igb: Request igb_msix_other as a threaded interrupt handler
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250505/202505051357.VxQIHWOY-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250505/202505051357.VxQIHWOY-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505051357.VxQIHWOY-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/intel/igb/igb_main.c: In function 'igb_request_msix':
>> drivers/net/ethernet/intel/igb/igb_main.c:916:61: warning: passing argument 4 of 'request_threaded_irq' makes integer from pointer without a cast [-Wint-conversion]
916 | igb_msix_other, 0, netdev->name, adapter);
| ~~~~~~^~~~~~
| |
| char *
In file included from arch/x86/include/asm/highmem.h:24,
from include/linux/highmem-internal.h:25,
from include/linux/highmem.h:14,
from include/linux/pagemap.h:11,
from drivers/net/ethernet/intel/igb/igb_main.c:11:
include/linux/interrupt.h:153:36: note: expected 'long unsigned int' but argument is of type 'char *'
153 | unsigned long flags, const char *name, void *dev);
| ~~~~~~~~~~~~~~^~~~~
drivers/net/ethernet/intel/igb/igb_main.c:916:69: error: passing argument 5 of 'request_threaded_irq' from incompatible pointer type [-Werror=incompatible-pointer-types]
916 | igb_msix_other, 0, netdev->name, adapter);
| ^~~~~~~
| |
| struct igb_adapter *
include/linux/interrupt.h:153:55: note: expected 'const char *' but argument is of type 'struct igb_adapter *'
153 | unsigned long flags, const char *name, void *dev);
| ~~~~~~~~~~~~^~~~
drivers/net/ethernet/intel/igb/igb_main.c:915:15: error: too few arguments to function 'request_threaded_irq'
915 | err = request_threaded_irq(adapter->msix_entries[vector].vector,
| ^~~~~~~~~~~~~~~~~~~~
include/linux/interrupt.h:151:1: note: declared here
151 | request_threaded_irq(unsigned int irq, irq_handler_t handler,
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/request_threaded_irq +916 drivers/net/ethernet/intel/igb/igb_main.c
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 901
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 902 /**
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 903 * igb_request_msix - Initialize MSI-X interrupts
b980ac18c95f32 drivers/net/ethernet/intel/igb/igb_main.c Jeff Kirsher 2013-02-23 904 * @adapter: board private structure to initialize
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 905 *
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 906 * igb_request_msix allocates MSI-X vectors and requests interrupts from the
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 907 * kernel.
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 908 **/
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 909 static int igb_request_msix(struct igb_adapter *adapter)
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 910 {
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 911 unsigned int num_q_vectors = adapter->num_q_vectors;
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 912 struct net_device *netdev = adapter->netdev;
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 913 int i, err = 0, vector = 0, free_vector = 0;
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 914
086e5c4c0db155 drivers/net/ethernet/intel/igb/igb_main.c Sebastian Andrzej Siewior 2025-04-30 915 err = request_threaded_irq(adapter->msix_entries[vector].vector,
50d325bb05cef2 drivers/net/ethernet/intel/igb/igb_main.c Wander Lairson Costa 2024-11-06 @916 igb_msix_other, 0, netdev->name, adapter);
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 917 if (err)
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 918 goto err_out;
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 919
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 920 if (num_q_vectors > MAX_Q_VECTORS) {
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 921 num_q_vectors = MAX_Q_VECTORS;
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 922 dev_warn(&adapter->pdev->dev,
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 923 "The number of queue vectors (%d) is higher than max allowed (%d)\n",
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 924 adapter->num_q_vectors, MAX_Q_VECTORS);
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 925 }
6c19d772618fea drivers/net/ethernet/intel/igb/igb_main.c Aleksandr Loktionov 2021-04-22 926 for (i = 0; i < num_q_vectors; i++) {
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 927 struct igb_q_vector *q_vector = adapter->q_vector[i];
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 928
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 929 vector++;
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 930
7b06a6909555ff drivers/net/ethernet/intel/igb/igb_main.c Jarod Wilson 2015-10-19 931 q_vector->itr_register = adapter->io_addr + E1000_EITR(vector);
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 932
0ba829943c5180 drivers/net/ethernet/intel/igb/igb_main.c Alexander Duyck 2011-08-26 933 if (q_vector->rx.ring && q_vector->tx.ring)
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 934 sprintf(q_vector->name, "%s-TxRx-%u", netdev->name,
0ba829943c5180 drivers/net/ethernet/intel/igb/igb_main.c Alexander Duyck 2011-08-26 935 q_vector->rx.ring->queue_index);
0ba829943c5180 drivers/net/ethernet/intel/igb/igb_main.c Alexander Duyck 2011-08-26 936 else if (q_vector->tx.ring)
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 937 sprintf(q_vector->name, "%s-tx-%u", netdev->name,
0ba829943c5180 drivers/net/ethernet/intel/igb/igb_main.c Alexander Duyck 2011-08-26 938 q_vector->tx.ring->queue_index);
0ba829943c5180 drivers/net/ethernet/intel/igb/igb_main.c Alexander Duyck 2011-08-26 939 else if (q_vector->rx.ring)
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 940 sprintf(q_vector->name, "%s-rx-%u", netdev->name,
0ba829943c5180 drivers/net/ethernet/intel/igb/igb_main.c Alexander Duyck 2011-08-26 941 q_vector->rx.ring->queue_index);
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 942 else
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 943 sprintf(q_vector->name, "%s-unused", netdev->name);
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 944
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 945 err = request_irq(adapter->msix_entries[vector].vector,
a0607fd3a25ba1 drivers/net/igb/igb_main.c Joe Perches 2009-11-18 946 igb_msix_ring, 0, q_vector->name,
047e0030f1e601 drivers/net/igb/igb_main.c Alexander Duyck 2009-10-27 947 q_vector);
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 948 if (err)
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 949 goto err_free;
1911329ae9ce05 drivers/net/ethernet/intel/igb/igb_main.c Kurt Kanzenbach 2025-03-19 950
1911329ae9ce05 drivers/net/ethernet/intel/igb/igb_main.c Kurt Kanzenbach 2025-03-19 951 netif_napi_set_irq(&q_vector->napi,
1911329ae9ce05 drivers/net/ethernet/intel/igb/igb_main.c Kurt Kanzenbach 2025-03-19 952 adapter->msix_entries[vector].vector);
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 953 }
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 954
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 955 igb_configure_msix(adapter);
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 956 return 0;
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 957
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 958 err_free:
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 959 /* free already assigned IRQs */
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 960 free_irq(adapter->msix_entries[free_vector++].vector, adapter);
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 961
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 962 vector--;
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 963 for (i = 0; i < vector; i++) {
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 964 free_irq(adapter->msix_entries[free_vector++].vector,
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 965 adapter->q_vector[i]);
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 966 }
52285b762b3681 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2012-12-04 967 err_out:
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 968 return err;
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 969 }
9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 970
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the Intel-wired-lan
mailing list