[Intel-wired-lan] [PATCH iwl-net] ice/ptp: Fix reporting of crosstimestamp

Przemek Kitszel przemyslaw.kitszel at intel.com
Fri May 9 07:20:19 UTC 2025


On 5/8/25 14:52, Anton Nadezhdin wrote:
> Set use_nsecs=true as timestamp is reported in ns. Lack of this result

results

> in smaller timestamp error window which case error during phc2sys

window, what causes

> execution on some platforms:
> phc2sys[1768.256]: ioctl PTP_SYS_OFFSET_PRECISE: Invalid argument
> 
> Previously function convert_art_to_tsc was converting ts to the cycles
> instead of ns.
> 
> Testing hints (ethX is PF netdev):
> phc2sys -s ethX -c CLOCK_REALTIME  -O 37 -m
> 
> Fixes: d4bea547ebb57 (ice/ptp: Remove convert_art_to_tsc())
> Signed-off-by: Anton Nadezhdin <anton.nadezhdin at intel.com>

the change by itself looks good, please read [1] before sending v2
[1] https://wiki.ith.intel.com/x/ShT8vQ
(intel-workers-only link about our process)

> ---
>   drivers/net/ethernet/intel/ice/ice_ptp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c
> index 1fd1ae03eb90..11ed48a62b53 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp.c
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c
> @@ -2307,6 +2307,7 @@ static int ice_capture_crosststamp(ktime_t *device,
>   	ts = ((u64)ts_hi << 32) | ts_lo;
>   	system->cycles = ts;
>   	system->cs_id = CSID_X86_ART;
> +	system->use_nsecs = true;
>   
>   	/* Read Device source clock time */
>   	ts_lo = rd32(hw, cfg->dev_time_l[tmr_idx]);
> 
> base-commit: 7e5af365e38059ed585917623c1ba3a6c04a8c10



More information about the Intel-wired-lan mailing list