[Intel-wired-lan] [PATCH iwl-net] ice: Fix LACP bonds without SRIOV environment
Buvaneswaran, Sujai
sujai.buvaneswaran at intel.com
Fri May 9 12:00:14 UTC 2025
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Dave Ertman
> Sent: Tuesday, April 29, 2025 1:04 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Loktionov, Aleksandr <aleksandr.loktionov at intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix LACP bonds without SRIOV
> environment
>
> If an aggregate has the following conditions:
> - The SRIOV LAG DDP package has been enabled
> - The bond is in 802.3ad LACP mode
> - The bond is disqualified from supporting SRIOV VF LAG
> - Both interfaces were added simultaneously to the bond (same command)
>
> Then there is a chance that the two interfaces will be assigned different LACP
> Aggregator ID's. This will cause a failure of the LACP control over the bond.
>
> To fix this, we can detect if the primary interface for the bond (as defined by
> the driver) is not in switchdev mode, and exit the setup flow if so.
>
> Reproduction steps:
>
> %> ip link add bond0 type bond mode 802.3ad miimon 100 %> ip link set
> bond0 up %> ifenslave bond0 eth0 eth1 %> cat /proc/net/bonding/bond0 |
> grep Agg
>
> Check for Aggregator IDs that differ.
>
> Fixes: ec5a6c5f79ed ("ice: process events created by lag netdev event
> handler")
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
> Signed-off-by: Dave Ertman <david.m.ertman at intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_lag.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran at intel.com>
More information about the Intel-wired-lan
mailing list