[Intel-wired-lan] [External] : Re: [PATCH net-next] iavf: fix incorrect warning message in iavf_del_vlans()

[ALOK TIWARI]

On 10/27/2025 2:15 PM, Przemek Kitszel wrote:
>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/ 
>> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> index 34a422a4a29c..6ad91db027d3 100644
>> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> @@ -987,7 +987,7 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
>>           len = virtchnl_struct_size(vvfl_v2, filters, count);
>>           if (len > IAVF_MAX_AQ_BUF_SIZE) {
>> -            dev_warn(&adapter->pdev->dev, "Too many add VLAN changes 
>> in one request\n");
>> +            dev_warn(&adapter->pdev->dev, "Too many delete VLAN 
>> changes in one request\n");
>>               while (len > IAVF_MAX_AQ_BUF_SIZE)
>>                   len = virtchnl_struct_size(vvfl_v2, filters,
>>                                  --count);
> 
> As Simon said this is a clear copy-paste error.
> 
> But the message itself is not great:
> there is too many VLAN DEL requests to fit into 4k of memory, so what?
> driver will just split into multiple virtchnl messages (with the "loop"
> for splitting is put multiple call layers above from iavf_del_vlans()),
> and everything is expected to work fine (despite the fact that this is
> likely not tested frequently ;))
> 
> I would suggest to also lover the log message level to info, and
> rephrase as "Too many VLAN delete changes requested, splitting into 
> multiple messages to PF",
> or similar. And the same for ADD requests, the same for v1 message
> (so 4 cases total).
> 
> with that there will be no eyebrow raised for the dmesg reader

I will send a new patch for this, covering both ADD and DELETE cases
using dev_info.

Thanks,
Alok