[Intel-wired-lan] [Patch net v2] ice: Fix incorrect timeout ice_release_res()
Rinitha, SX
sx.rinitha at intel.com
Fri Jan 9 09:08:03 UTC 2026
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Ding Hui
> Sent: 06 December 2025 19:16
> To: Nguyen, Anthony L <anthony.l.nguyen at intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel at intel.com>; andrew+netdev at lunn.ch; davem at davemloft.net; edumazet at google.com; kuba at kernel.org; pabeni at redhat.com; Keller, Jacob E <jacob.e.keller at intel.com>; intel-wired-lan at lists.osuosl.org
> Cc: netdev at vger.kernel.org; linux-kernel at vger.kernel.org; Ding, Hui <dinghui at sangfor.com.cn>
> Subject: [Intel-wired-lan] [Patch net v2] ice: Fix incorrect timeout ice_release_res()
>
> The commit 5f6df173f92e ("ice: implement and use rd32_poll_timeout for ice_sq_done timeout") converted ICE_CTL_Q_SQ_CMD_TIMEOUT from jiffies to microseconds.
>
> But the ice_release_res() function was missed, and its logic still treats ICE_CTL_Q_SQ_CMD_TIMEOUT as a jiffies value.
>
> So correct the issue by usecs_to_jiffies().
>
> Found by inspection of the DDP downloading process.
> Compile and modprobe tested only.
>
> Fixes: 5f6df173f92e ("ice: implement and use rd32_poll_timeout for ice_sq_done timeout")
> Signed-off-by: Ding Hui <dinghui at sangfor.com.cn>
> Reviewed-by: Simon Horman <horms at kernel.org>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ---
> v1->v2: rebase to net branch and add commit log.
>
Tested-by: Rinitha S <sx.rinitha at intel.com> (A Contingent worker at Intel)
More information about the Intel-wired-lan
mailing list