[Intel-wired-lan] [PATCH net v2] iavf: fix deadlock in reset handling
Jacob Keller
jacob.e.keller at intel.com
Wed Feb 11 18:50:03 UTC 2026
On 2/11/2026 3:50 AM, Paolo Abeni wrote:
> On 2/7/26 11:22 AM, Petr Oros wrote:
>> -/**
>> - * iavf_wait_for_reset - Wait for reset to finish.
>> - * @adapter: board private structure
>> - *
>> - * Returns 0 if reset finished successfully, negative on timeout or interrupt.
>> - */
>> -int iavf_wait_for_reset(struct iavf_adapter *adapter)
>> -{
>> - int ret = wait_event_interruptible_timeout(adapter->reset_waitqueue,
>> - !iavf_is_reset_in_progress(adapter),
>> - msecs_to_jiffies(5000));
>
> AFAICS, after this change nobody waits anymore on reset_waitqueue, do we
> still need such wait queue head? I think a bunch of additional code
> could be dropped.
>
> Thanks,
>
> Paolo
>
Yea, that seems correct. We could do that cleanup through next instead
if we want to keep this patch smaller and focused on the fix. I don't
mind either way.
Thanks,
Jake
More information about the Intel-wired-lan
mailing list