[Intel-wired-lan] [PATCH net] drivers: net: ice: fix devlink parameters get without irdma
Loktionov, Aleksandr
aleksandr.loktionov at intel.com
Fri Feb 13 09:15:47 UTC 2026
> -----Original Message-----
> From: Nikolay Aleksandrov <nikolay at nvidia.com>
> Sent: Friday, February 13, 2026 9:49 AM
> To: netdev at vger.kernel.org
> Cc: David Ahern <dsahern at kernel.org>; Nguyen, Anthony L
> <anthony.l.nguyen at intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel at intel.com>; Andrew Lunn <andrew+netdev at lunn.ch>;
> davem at davemloft.net; Eric Dumazet <edumazet at google.com>; Jakub
> Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>;
> Loktionov, Aleksandr <aleksandr.loktionov at intel.com>; Greenwalt, Paul
> <paul.greenwalt at intel.com>; Daniel Zahka <daniel.zahka at gmail.com>;
> Michal Swiatkowski <michal.swiatkowski at linux.intel.com>; Ertman, David
> M <david.m.ertman at intel.com>; Mustafa Ismail
> <mustafa.ismail at intel.com>; Shiraz Saleem <shiraz.saleem at intel.com>;
> Nikolova, Tatyana E <tatyana.e.nikolova at intel.com>; intel-wired-
> lan at lists.osuosl.org; Nikolay Aleksandrov <nikolay at nvidia.com>
> Subject: [PATCH net] drivers: net: ice: fix devlink parameters get
> without irdma
>
> If CONFIG_IRDMA isn't enabled but there are ice NICs in the system,
> the driver will prevent full devlink dev param show dump because its
> rdma get callbacks return ENODEV and stop the dump. For example:
> $ devlink dev param show
> pci/0000:82:00.0:
> name msix_vec_per_pf_max type generic
> values:
> cmode driverinit value 2
> name msix_vec_per_pf_min type generic
> values:
> cmode driverinit value 2
> kernel answers: No such device
>
> Returning EOPNOTSUPP allows the dump to continue so we can see all
> devices'
> devlink parameters.
>
> Fixes: c24a65b6a27c ("iidc/ice/irdma: Update IDC to support multiple
> consumers")
> Signed-off-by: Nikolay Aleksandrov <nikolay at nvidia.com>
> ---
> drivers/net/ethernet/intel/ice/devlink/devlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> index 2ef39cc70c21..7de749d3f047 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> @@ -1360,7 +1360,7 @@ ice_devlink_enable_roce_get(struct devlink
> *devlink, u32 id,
>
> cdev = pf->cdev_info;
> if (!cdev)
> - return -ENODEV;
> + return -EOPNOTSUPP;
>
> ctx->val.vbool = !!(cdev->rdma_protocol &
> IIDC_RDMA_PROTOCOL_ROCEV2);
>
> @@ -1427,7 +1427,7 @@ ice_devlink_enable_iw_get(struct devlink
> *devlink, u32 id,
>
> cdev = pf->cdev_info;
> if (!cdev)
> - return -ENODEV;
> + return -EOPNOTSUPP;
>
> ctx->val.vbool = !!(cdev->rdma_protocol &
> IIDC_RDMA_PROTOCOL_IWARP);
>
> --
> 2.47.3
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
More information about the Intel-wired-lan
mailing list