[Intel-wired-lan] [PATCH iwl-net] ice: fix missing dpll notification for SW pins

[Kwapulinski, Piotr]

>From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> on behalf of Petr Oros <poros at redhat.com>
>Sent: Wednesday, February 18, 2026 10:14 PM
>To: netdev at vger.kernel.org <netdev at vger.kernel.org>
>Cc: Vecera, Ivan <ivecera at redhat.com>; Kitszel, Przemyslaw <przemyslaw.kitszel at intel.com>; Eric Dumazet <edumazet at google.com>; Kubalewski, Arkadiusz <arkadiusz.kubalewski at intel.com>; Andrew Lunn <andrew+netdev at lunn.ch>; Nguyen, Anthony L <anthony.l.nguyen at intel.com>; Simon Horman <horms at kernel.org>; intel-wired-lan at lists.osuosl.org <intel-wired-lan at lists.osuosl.org>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni <pabeni at redhat.com>; David S. Miller <davem at davemloft.net>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>
>Subject: [Intel-wired-lan] [PATCH iwl-net] ice: fix missing dpll notification for SW pins
>
>ice_dpll_notify_changes() sends dpll_pin_change_ntf() only for the
>direct CGU input pin stored in d->active_input. Software-controlled
>pins (SMA/U.FL) are separate dpll_pin objects that wrap a backing CGU
>input, but they never receive a change notification. As a result,
>userspace consumers such as synce4l that monitor SMA pins via dpll
>netlink never learn when the pin state transitions (e.g. from
>SELECTABLE to CONNECTED), even though 'dpll pin show' reports the
>correct state on demand.
>
>
>When the active input changes, also send dpll_pin_change_ntf() for any
>registered SMA/U.FL input pin whose backing CGU input matches the old
>or new active input.
>
>
>Fixes: 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control")
>Signed-off-by: Petr Oros <poros at redhat.com>
>---
> drivers/net/ethernet/intel/ice/ice_dpll.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
>
>diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c
>index c2ad39bfe177db..6f855fe4c78d62 100644
>--- a/drivers/net/ethernet/intel/ice/ice_dpll.c
>+++ b/drivers/net/ethernet/intel/ice/ice_dpll.c
>@@ -2470,13 +2470,17 @@ static u64 ice_generate_clock_id(struct ice_pf *pf)
>  */
> static void ice_dpll_notify_changes(struct ice_dpll *d)
> {
>+       struct ice_dplls *dplls = &d->pf->dplls;
>         bool pin_notified = false;
>+       int i;

Please declare within a loop itself
Piotr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20260219/45e718a2/attachment-0001.htm>