[Intel-wired-lan] [PATCH iwl-next v7 14/14] ixd: add devlink support

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf
> Of Larysa Zaremba
> Sent: Tuesday, April 28, 2026 10:27 AM
> To: intel-wired-lan at lists.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen at intel.com>
> Cc: Lobakin, Aleksander <aleksander.lobakin at intel.com>; Samudrala,
> Sridhar <sridhar.samudrala at intel.com>; Michal Swiatkowski
> <michal.swiatkowski at linux.intel.com>; Zaremba, Larysa
> <larysa.zaremba at intel.com>; Fijalkowski, Maciej
> <maciej.fijalkowski at intel.com>; Tantilov, Emil S
> <emil.s.tantilov at intel.com>; Chittim, Madhu <madhu.chittim at intel.com>;
> Hay, Joshua A <joshua.a.hay at intel.com>; Keller, Jacob E
> <jacob.e.keller at intel.com>; Shanmugam, Jayaprakash
> <jayaprakash.shanmugam at intel.com>; Jiri Pirko <jiri at resnulli.us>;
> David S. Miller <davem at davemloft.net>; Eric Dumazet
> <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni
> <pabeni at redhat.com>; Simon Horman <horms at kernel.org>; Jonathan Corbet
> <corbet at lwn.net>; Richard Cochran <richardcochran at gmail.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel at intel.com>; Andrew Lunn
> <andrew+netdev at lunn.ch>; netdev at vger.kernel.org; linux-
> doc at vger.kernel.org; linux-kernel at vger.kernel.org; R, Bharath
> <bharath.r at intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v7 14/14] ixd: add devlink
> support
> 
> From: Amritha Nambiar <amritha.nambiar at intel.com>
> 
> Enable initial support for the devlink interface with the ixd driver.
> The ixd hardware is a single function PCIe device. So, the PCIe
> adapter gets its own devlink instance to manage device-wide resources
> or configuration.
> 
> $ devlink dev show
> pci/0000:83:00.6
> 
> $ devlink dev info pci/0000:83:00.6
> pci/0000:83:00.6:
>   driver ixd
>   serial_number 00-a0-c9-ff-ff-23-45-67
>   versions:
>       fixed:
>         device.type MEV
>       running:
>         virtchnl 2.0
> 
> Signed-off-by: Amritha Nambiar <amritha.nambiar at intel.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski at linux.intel.com>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski at intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel at intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba at intel.com>
> Tested-by: Bharath R <Bharath.r at intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen at intel.com>
> ---
>  Documentation/networking/devlink/index.rst   |  1 +
>  Documentation/networking/devlink/ixd.rst     | 30 ++++++
>  drivers/net/ethernet/intel/ixd/Kconfig       |  1 +
>  drivers/net/ethernet/intel/ixd/Makefile      |  1 +
>  drivers/net/ethernet/intel/ixd/ixd_devlink.c | 97
> ++++++++++++++++++++  drivers/net/ethernet/intel/ixd/ixd_devlink.h |
> 44 +++++++++
>  drivers/net/ethernet/intel/ixd/ixd_main.c    | 16 +++-
>  7 files changed, 187 insertions(+), 3 deletions(-)  create mode
> 100644 Documentation/networking/devlink/ixd.rst
>  create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.c
>  create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.h
> 
> diff --git a/Documentation/networking/devlink/index.rst
> b/Documentation/networking/devlink/index.rst
> index f7ba7dcf477d..f0c077843fa7 100644
> --- a/Documentation/networking/devlink/index.rst
> +++ b/Documentation/networking/devlink/index.rst
> @@ -88,6 +88,7 @@ parameters, info versions, and other features it
> supports.
>     ionic
>     iosm
>     ixgbe

...

> --- /dev/null
> +++ b/drivers/net/ethernet/intel/ixd/ixd_devlink.h
> @@ -0,0 +1,44 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2025, Intel Corporation. */
> +
devlink.c  has:
> +// SPDX-License-Identifier: GPL-2.0
But devlink.h has:
> +/* SPDX-License-Identifier: GPL-2.0 */

Why?

> +#ifndef _IXD_DEVLINK_H_
> +#define _IXD_DEVLINK_H_
> +#include <net/devlink.h>

...

>  }
> 
>  static const struct pci_device_id ixd_pci_tbl[] = {
> --
> 2.47.0