[Intel-wired-lan] [PATCH iwl-next v7 09/14] idpf: make mbx_task queueing and cancelling more consistent

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf
> Of Larysa Zaremba
> Sent: Tuesday, April 28, 2026 10:27 AM
> To: intel-wired-lan at lists.osuosl.org; Nguyen, Anthony L
> <anthony.l.nguyen at intel.com>
> Cc: Lobakin, Aleksander <aleksander.lobakin at intel.com>; Samudrala,
> Sridhar <sridhar.samudrala at intel.com>; Michal Swiatkowski
> <michal.swiatkowski at linux.intel.com>; Zaremba, Larysa
> <larysa.zaremba at intel.com>; Fijalkowski, Maciej
> <maciej.fijalkowski at intel.com>; Tantilov, Emil S
> <emil.s.tantilov at intel.com>; Chittim, Madhu <madhu.chittim at intel.com>;
> Hay, Joshua A <joshua.a.hay at intel.com>; Keller, Jacob E
> <jacob.e.keller at intel.com>; Shanmugam, Jayaprakash
> <jayaprakash.shanmugam at intel.com>; Jiri Pirko <jiri at resnulli.us>;
> David S. Miller <davem at davemloft.net>; Eric Dumazet
> <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni
> <pabeni at redhat.com>; Simon Horman <horms at kernel.org>; Jonathan Corbet
> <corbet at lwn.net>; Richard Cochran <richardcochran at gmail.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel at intel.com>; Andrew Lunn
> <andrew+netdev at lunn.ch>; netdev at vger.kernel.org; linux-
> doc at vger.kernel.org; linux-kernel at vger.kernel.org; Salin, Samuel
> <samuel.salin at intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v7 09/14] idpf: make
> mbx_task queueing and cancelling more consistent
> 
> As a consequence of refactoring idpf code to use libeth APIs,
> idpf_vc_xn_shutdown was merged with and replaced by
> idpf_deinit_dflt_mbx.
> This does not affect the Tx path, as it checked for a presence of an
> xn manager anyway. Rx processing is handled by the mbx_task that is
> not always cancelled before calling the new consolidated mailbox
> deinit function.
> Moreover, in the reset path idpf_intr_rel() reschedules it after the
> deinit is done. This leads to mbx_task referencing the freed mailbox
> and causing KASAN warnings.
> 
> To remedy this, in the init path, do the first queueing of mbx_task in
> idpf_init_dflt_mbx(), in deinit and reset, always cancel the task in
> idpf_deinit_dflt_mbx() and in every flow first call
> idpf_mb_intr_rel_irq().
> 
> Reviewed-by: Emil Tantilov <emil.s.tantilov at intel.com>
> Reviewed-by: Michal Kubiak <michal.kubiak at intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba at intel.com>
> Tested-by: Samuel Salin <Samuel.salin at intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen at intel.com>
> ---
>  drivers/net/ethernet/intel/idpf/idpf.h          | 1 +
>  drivers/net/ethernet/intel/idpf/idpf_lib.c      | 9 ++++-----
>  drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 6 +++++-
>  3 files changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h
> b/drivers/net/ethernet/intel/idpf/idpf.h
> index 679539a1b947..1d0e32e47e87 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf.h
> @@ -984,6 +984,7 @@ void idpf_vc_event_task(struct work_struct *work);
> void idpf_dev_ops_init(struct idpf_adapter *adapter);  void
> idpf_vf_dev_ops_init(struct idpf_adapter *adapter);  int
> idpf_intr_req(struct idpf_adapter *adapter);
> +void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter);
>  void idpf_intr_rel(struct idpf_adapter *adapter);
>  u16 idpf_get_max_tx_hdr_size(struct idpf_adapter *adapter);  int
> idpf_initiate_soft_reset(struct idpf_vport *vport, diff --git
> a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> index 0d131bf0993e..7988836fbae0 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> @@ -68,9 +68,11 @@ static void idpf_deinit_vector_stack(struct
> idpf_adapter *adapter)
>   * This will also disable interrupt mode and queue up mailbox task.
> Mailbox
>   * task will reschedule itself if not in interrupt mode.
>   */

...

> 
>  	idpf_vport_params_buf_rel(adapter);
> 
> --
> 2.47.0


Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>