[Intel-wired-lan] [PATCH iwl-net v5 2/4] ixgbe: fix cls_u32 nexthdr path returning success when no entry installed

[Rinitha, SX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of Aleksandr Loktionov
> Sent: 16 May 2026 00:34
> To: intel-wired-lan at lists.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen at intel.com>; Loktionov, Aleksandr <aleksandr.loktionov at intel.com>
> Cc: netdev at vger.kernel.org; Simon Horman <horms at kernel.org>; Marcin Szycik <marcin.szycik at linux.intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net v5 2/4] ixgbe: fix cls_u32 nexthdr path returning success when no entry installed
>
> ixgbe_configure_clsu32() returns 0 (success) after the nexthdr loop even when ixgbe_clsu32_build_input() fails for every candidate entry and no jump-table slot is actually programmed.  Callers that test the return value would then falsely believe > the filter was installed.
>
> The variable 'err' already tracks the last ixgbe_clsu32_build_input() return value; if the loop completes with a successful break, err is 0.
> If all attempts failed, err holds the last failure code.  Change the unconditional 'return 0' to 'return err' so errors are propagated correctly.
>
> Fixes: 1cdaaf5405ba ("ixgbe: Match on multiple headers for cls_u32 offloads")
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
> Cc: stable at vger.kernel.org
> Reviewed-by: Simon Horman <horms at kernel.org>
> Reviewed-by: Marcin Szycik <marcin.szycik at linux.intel.com>
> ---
> v2 -> v3:
> - Add Reviewed-by: Simon Horman; no code change.
>
> v1 -> v2:
> - Add Fixes: tag; reroute from iwl-next to iwl-net (false-success
>   return is a user-visible correctness bug, not a cleanup).
>
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Rinitha S <sx.rinitha at intel.com> (A Contingent worker at Intel)