[Maintain] Using names instead of numbers in DHCP config
Greg Connor
gconnor at sgi.com
Tue Apr 26 16:34:53 PDT 2005
On Tue, 26 Apr 2005, Brandon Philips wrote:
> > Here is a quick patch to be able to put names instead of numbers in for
> > "domain-name-servers". I will probably do the same for "netbios-name-servers"
> > as well...
>
> Sounds good.
As it turns out, netbios-name-servers didn't need a patch applied, it already
accepted names as OK.
> My only comment on the patch is that it is not necessary to instantiate
> a new domain in order to call is_valid_domain. I will make that change
> when I apply the patch, so just FYI.
Right... If I had bothered to scroll down a bit I would have seen the logic
that does this for the other options, which is somewhat cleaner:
if (!$ip->is_dotted_quad(trim($ip_addr)) && !$conf['ui']->is_domain($value)
&& !$valid) {
Thanks for the help!
gregc
More information about the Maintain
mailing list