[Replicant] [PATCH] Disable phone number lookup by default for privacy

[Fil]

Hi everyone,

here's a patch for Issue #1827 [1].
The patch is to be applied in the "vendor/cmsdk" project in the
Replicant tree.
It sets default values for the following anti-features, disabling them
by default:

- Forward phone number lookup
- Reverse phone number lookup
- People lookup

When applied, the patch causes the following behaviour:

- A fresh new replicant installation with my patch has lookup services
disabled by default (and I detected no dns query to lookup services).
- Enabling lookup "features" manually in the dialer app makes them work
again (at least I detected some dns queries to whitepages-like services
when the features are enabled)
- Doing a "factory reset" when lookup is enabled results in lookup
anti-features being disabled again as the default configuration expects.

Like Denis and Wolfgang pointed out [2], it is important to disable
these "features" by default, to avoid privacy leaks and unwanted network
traffic without the user knowing.
This services should only be enabled by an explicit manual action of the
user.

I have only conducted a brief test case using the configuration
suggested by Denis [3], and the outcome seems to confirm that disabling
these anti-features in the settings does cease network traffic towards
lookup services, but further/deeper investigation is needed.

For the moment, I suggest disabling the anti-features by default.

Happy hacking,

Fil

[1] https://redmine.replicant.us/issues/1827
[2] https://redmine.replicant.us/issues/1827#note-2
[3] https://redmine.replicant.us/issues/1827#note-5


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Disable-phone-number-lookup-by-default-for-privacy.patch
Type: text/x-patch
Size: 1645 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20181229/7de0c943/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20181229/7de0c943/attachment.asc>