[Replicant] [PATCH] Native Wi-Fi for external dongles

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Tue Mar 5 22:05:18 UTC 2019


On Sat, 15 Dec 2018 17:04:38 +0000
Belgin ?tirbu <belginstirbu at hotmail.com> wrote:

Thanks a lot for the patch.

I've some comments on it below.

> To be applied in the base source folder.
> 
> patch -p0 < 6.0-wifi-dongle.patch
Would it be possible for you to make a git commit with:
- a commit message describing the change.
- a signed-off-by like (that can be generated with git commit -s)

[...]
> -WIFI_DRIVER_MODULE_PATH          := "/system/lib/modules/dhd.ko"
> +#WIFI_DRIVER_MODULE_PATH          := "/system/lib/modules/dhd.ko"
>  WIFI_DRIVER_FW_PATH_PARAM        :=
> "/sys/module/dhd/parameters/firmware_path"
> -WIFI_DRIVER_FW_PATH_STA          :=
> "/vendor/firmware/bcmdhd_sta.bin"
> -WIFI_DRIVER_FW_PATH_AP           :=
> "/vendor/firmware/bcmdhd_apsta.bin"
> -WIFI_DRIVER_FW_PATH_P2P          :=
> "/vendor/firmware/bcmdhd_p2p.bin"
> +#WIFI_DRIVER_FW_PATH_STA          :=
> "/vendor/firmware/bcmdhd_sta.bin"
> +#WIFI_DRIVER_FW_PATH_AP           :=
> "/vendor/firmware/bcmdhd_apsta.bin"
> +#WIFI_DRIVER_FW_PATH_P2P          :=
> "/vendor/firmware/bcmdhd_p2p.bin" WIFI_DRIVER_MODULE_NAME          :=
> "dhd" -WIFI_DRIVER_MODULE_ARG           :=
> "firmware_path=/vendor/firmware/bcmdhd_sta.bin
> nvram_path=/vendor/firmware/nvram_net.txt"
> -WIFI_DRIVER_MODULE_AP_ARG        :=
> "firmware_path=/vendor/firmware/bcmdhd_apsta.bin
> nvram_path=/vendor/firmware/nvram_net.txt"
> +#WIFI_DRIVER_MODULE_ARG           :=
> "firmware_path=/vendor/firmware/bcmdhd_sta.bin
> nvram_path=/vendor/firmware/nvram_net.txt"
> +#WIFI_DRIVER_MODULE_AP_ARG        :=
> "firmware_path=/vendor/firmware/bcmdhd_apsta.bin
> nvram_path=/vendor/firmware/nvram_net.txt"
> WIFI_BAND                        := 802_11_ABG
> BOARD_HAVE_SAMSUNG_WIFI          := true
I think it's best to remove the lines instead of commenting them.

> +LOCAL_CFLAGS += -DWIFI_DRIVER_FW_PATH_STA=0
> +LOCAL_CFLAGS += -DWIFI_DRIVER_FW_PATH_AP=0
> +LOCAL_CFLAGS += -DWIFI_DRIVER_FW_PATH_P2P=0
> +LOCAL_CFLAGS += -DWIFI_DRIVER_MODULE_ARG=0
> +LOCAL_CFLAGS += -DWIFI_DRIVER_MODULE_AP_ARG=0
Do you have more insights as why both changes above
make external WiFi dongles work? If you do it would be nice to explain
it somewhere, for instance in the commit message.

> +++ external/wpa_supplicant_8/src/drivers/android_drv.h
> @@ -13,7 +13,7 @@
>  #define MAX_SSID_LEN 32
>  
>  #define MAX_DRV_CMD_SIZE		248
> -#define DRV_NUMBER_SEQUENTIAL_ERRORS	4
> +#define DRV_NUMBER_SEQUENTIAL_ERRORS	40
This seem to imply that there are some errors going on.
Do you have some more context on the errors?

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20190305/70553318/attachment.asc>


More information about the Replicant mailing list