[Replicant] [PATCH] Hide information leaking phone number lookup settings

Fil Lupin fillupin at protonmail.com
Thu Oct 10 12:09:12 UTC 2019


Hi Joonas,
thanks for your work on this.

Should we not submit this patch also to LineageOS repo?
Do you think they will not be interested?
This could help making some users/developpers realize that android is not exempt of privacy issues.

- Fil Lupin.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, October 9, 2019 9:41 PM, Joonas Kylmälä <joonas.kylmala at iki.fi> wrote:

> Hi,
>
> this patch is applied to
> https://git.replicant.us/LineageOS-mirror/android_packages_apps_Dialer/.
> That is now a LineageOS mirror repo so if this patch is reviewed and
> accepted we need to fork the LineageOS repo.
>
> Joonas
>
> Joonas Kylmälä:
>
> > The phone number lookup service leaks private information so hide the
> > option to enable it.
> >
> > Signed-off-by: Joonas Kylmälä joonas.kylmala at iki.fi
> >
> > ----------------------------------------------------
> >
> > src/com/android/dialer/settings/DialerSettingsActivity.java | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/src/com/android/dialer/settings/DialerSettingsActivity.java b/src/com/android/dialer/settings/DialerSettingsActivity.java
> > index 52d91104..ce27d427 100644
> > --- a/src/com/android/dialer/settings/DialerSettingsActivity.java
> > +++ b/src/com/android/dialer/settings/DialerSettingsActivity.java
> > @@ -204,7 +204,7 @@ public class DialerSettingsActivity extends PreferenceActivity {
> > lookupSettingsHeader.titleRes = R.string.lookup_settings_label;
> > lookupSettingsHeader.summaryRes = R.string.lookup_settings_description;
> > lookupSettingsHeader.fragment = LookupSettingsFragment.class.getName();
> >
> > -          target.add(lookupSettingsHeader);
> >
> >
> >
> > -          // target.add(lookupSettingsHeader);
> >
> >            // Only add the call settings header if the current user is the primary/owner user.
> >            if (isPrimaryUser()) {
> >
> >
>
> Replicant mailing list
> Replicant at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/replicant




More information about the Replicant mailing list