[Replicant] [PATCH v3] Remove phone number lookup settings in the graphical interface

[Denis 'GNUtoo' Carikli]

On Sun, 27 Oct 2019 16:15:26 +0200
Joonas Kylmälä <joonas.kylmala at iki.fi> wrote:

> When the phone number lookup settings were enabled the app was leaking
> private information. To prevent that, the following commits in
> vendor/cmsdk disabled it by default and made sure that the settings
> were switched back to disabled:
> 
> de9e5b0 Disable phone number lookup by default for privacy
> 2d8ae47 Disable phone number lookup settings during upgrade
> 
> This change removes the phone number lookup service from the graphical
> interface as well. If we wouldn't remove it then users could still
> enable it without understanding that it leaks private information to
> third parties.
> 
> Signed-off-by: Joonas Kylmälä <joonas.kylmala at iki.fi>
> ---
>  src/com/android/dialer/settings/DialerSettingsActivity.java | 6
> ------ 1 file changed, 6 deletions(-)
> 
> diff --git
> a/src/com/android/dialer/settings/DialerSettingsActivity.java
> b/src/com/android/dialer/settings/DialerSettingsActivity.java index
> 52d91104..8db2e809 100644 ---
> a/src/com/android/dialer/settings/DialerSettingsActivity.java +++
> b/src/com/android/dialer/settings/DialerSettingsActivity.java @@
> -200,12 +200,6 @@ public class DialerSettingsActivity extends
> PreferenceActivity { quickResponseSettingsHeader.intent =
> quickResponseSettingsIntent; target.add(quickResponseSettingsHeader); 
> -        final Header lookupSettingsHeader = new Header();
> -        lookupSettingsHeader.titleRes =
> R.string.lookup_settings_label;
> -        lookupSettingsHeader.summaryRes =
> R.string.lookup_settings_description;
> -        lookupSettingsHeader.fragment =
> LookupSettingsFragment.class.getName();
> -        target.add(lookupSettingsHeader);
> -
>          // Only add the call settings header if the current user is
> the primary/owner user. if (isPrimaryUser()) {
>              final TelephonyManager telephonyManager =
Acked-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20191029/f30effb2/attachment.asc>