[Replicant] [manifest][PATCH] Move libsamsung-ril and libsamsung-ipc in vendor/replicant

Joonas Kylmälä joonas.kylmala at iki.fi
Sat Apr 4 14:03:03 UTC 2020


Hi,

Just FYI: I will be pushing similar patch for replicant-9 manifest.

Denis 'GNUtoo' Carikli:
> This unify the naming of libsamsung-ril which is sometimes
> called samsung-ril and sometimes libsamsung-ril.
> 
> Using the samsung-ril naming is confusing because it would
> imply that it's not a libril implementation but instead a
> complete RIL implementation.
> 
> Having libsamsung-ipc in the external/ directory might make
> sense as all non Android specifics repositories are there.
> But since the repository names are based on their location
> it ended up being external_libsamsung-ipc.
> 
> Having the repository named external_libsamsung-ipc is very
> confusing: it can and probably did make people think that
> Replicant wasn't maintaining it, and that the upstream
> project was hosted somewhere else.
> 
> This is really problematic as Replicant is trying to
> collaborate with other projects like GNU/Linux
> distributions whose contributors might not be familiar with
> the Android naming scheme.
> 
> As libsamsung-ipc is meant to be used in GNU/Linux as well
> and that Replicant also accepts contributions from other
> distributions, including contributions for devices that
> Replicant decided not to support in Replicant because
> they attack users freedom privacy and security more than
> the devices already supported by Replicant.
> 
> The move of libsamsung-ipc and libsamsung-ril in
> hardware/replicant also makes it more clear that Replicant
> is the upstream project for both repositories.
> 
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
> ---
>  default.xml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/default.xml b/default.xml
> index caca595..843d796 100644
> --- a/default.xml
> +++ b/default.xml
> @@ -536,8 +536,8 @@
>    <project path="device/samsung/smdk4412-common" name="replicant/device_samsung_smdk4412-common.git" remote="replicant" />
>    <project path="device/samsung/smdk4412-qcom-common" name="LineageOS-mirror/android_device_samsung_smdk4412-qcom-common.git" />
>      <project path="device/samsung/kona-common" name="replicant/device_samsung_kona-common.git" remote="replicant" />
> -  <project path="hardware/ril/samsung-ril" name="replicant/hardware_ril_samsung-ril.git" remote="replicant" />
> -  <project path="external/libsamsung-ipc" name="replicant/external_libsamsung-ipc.git" remote="replicant" />
> +  <project path="hardware/replicant/libsamsung-ril" name="replicant/hardware_replicant_libsamsung-ril.git" remote="replicant" />
> +  <project path="hardware/replicant/libsamsung-ipc" name="replicant/hardware_replicant_libsamsung-ipc.git" remote="replicant" />
>    <project path="packages/apps/SamsungServiceMode" name="LineageOS-mirror/android_packages_apps_SamsungServiceMode.git" />
>    <project path="hardware/samsung" name="LineageOS-mirror/android_hardware_samsung.git" />
>    <project path="hardware/tinyalsa-audio" name="replicant/hardware_tinyalsa-audio.git" remote="replicant" />
> 


More information about the Replicant mailing list