[Replicant] [libsamsung-ipc][PATCH 02/48] tools: ipc-test: switch to Linux code style

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Mon Apr 6 21:35:29 UTC 2020


On Sun, 05 Apr 2020 22:48:41 +0000
Fil Lupin <fillupin at protonmail.com> wrote:

> Since it seems only style changes, it would be easier if some tools
> could be used to check some already written files. I did not find
> cppcheck rules for linux kernel coding conventions
I've locally integrated checkpatch.pl and started checking things with
it. Not all the commits nor files pass the check.

I'll send a v2 with checkpatch.pl and hopefully with all the commits and
files pass the check.

If splitting the patchset in smaller patchsets helps I can do that too
as there won't be about 50 patches to review in one go.

Do you think it's a good idea to include the output of checkpatch.pl on
the files in the commit messages (with --ignore <check_name> when
relevant)?

Thanks for catching the issue, I've sent the patchset way too early.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20200406/704c28eb/attachment.asc>


More information about the Replicant mailing list