[Replicant] [libsamsung-ril] [PATCH 1/8] ss: remove unused state variable

Joonas Kylmälä joonas.kylmala at iki.fi
Fri Aug 21 22:04:59 UTC 2020


Hi,

Denis 'GNUtoo' Carikli:
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
> ---
>  ss.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/ss.c b/ss.c
> index 49f3152..59e134f 100644
> --- a/ss.c
> +++ b/ss.c
> @@ -214,7 +214,9 @@ complete:
>  	return rc;
>  }
>  
> -int ril_request_cancel_ussd(void *data, size_t size, RIL_Token token)
> +int ril_request_cancel_ussd(__attribute__((unused)) void *data,
> +			    __attribute__((unused)) size_t size,
> +			    RIL_Token token)

Is this change also intended? According to the commit message only the
change below looks to be intended to be done.

>  	struct ipc_ss_ussd_header ussd;
>  	int rc;
> @@ -419,7 +421,6 @@ int ipc_ss_ussd(struct ipc_message *message)
>  	char *ussd_message[2];
>  	int ussd_encoding;
>  	struct ipc_ss_ussd_header *ussd = NULL;
> -	unsigned char state;
>  	int rc;
>  
>  	if (message == NULL || message->data == NULL || message->size < sizeof(struct ipc_ss_ussd_header))
> 


More information about the Replicant mailing list