[Replicant] [libsamsung-ril] [PATCH 1/8] ss: remove unused state variable

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Thu Aug 27 15:33:52 UTC 2020


On Sat, 22 Aug 2020 01:04:59 +0300
Joonas Kylmälä <joonas.kylmala at iki.fi> wrote:

> Hi,
> 
> Denis 'GNUtoo' Carikli:
> > Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
> > ---
> >  ss.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ss.c b/ss.c
> > index 49f3152..59e134f 100644
> > --- a/ss.c
> > +++ b/ss.c
> > @@ -214,7 +214,9 @@ complete:
> >  	return rc;
> >  }
> >  
> > -int ril_request_cancel_ussd(void *data, size_t size, RIL_Token
> > token) +int ril_request_cancel_ussd(__attribute__((unused)) void
> > *data,
> > +			    __attribute__((unused)) size_t size,
> > +			    RIL_Token token)
> 
> Is this change also intended? According to the commit message only the
> change below looks to be intended to be done.
It's not, it's probably an artefact of rebases operations.

Thanks a lot for the catch.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20200827/b16b88bf/attachment.asc>


More information about the Replicant mailing list