[Replicant] [libsamsung-ipc] [PATCH 2/2] ipc_nv_data_md5_calculate: handle size mismatch better

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Tue Dec 1 21:52:58 UTC 2020


On Tue,  1 Dec 2020 16:40:27 +0100
Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org> wrote:

> +	if (st.st_size != size) {
Hmmm, I forgot to run the build test, that makes them fail as we got
the same issue than the previous patches are trying to fix: 
> samsung-ipc/rfs.c:61:17: error: comparison of integers of different
> signs: 
> '__off_t' (aka 'long') and 'size_t' (aka 'unsigned int')
> [-Werror,-Wsign-compare] if (st.st_size != size)
>                            { ~~~~~~~~~~ ^  ~~~~
> samsung-ipc/rfs.c:61:17: error: comparison of integers of different
> signs:
> '__off_t' (aka 'long') and 'size_t' (aka 'unsigned int')
> [-Werror,-Wsign-compare] if (st.st_size != size)
>                            { ~~~~~~~~~~ ^  ~~~~

I'll fix that too.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20201201/af6fba6d/attachment.asc>


More information about the Replicant mailing list