[Replicant] [libsamsung-ril] [PATCH] Android.mk: remove hardcoded reference to external/libsamsung-ipc

[Denis 'GNUtoo' Carikli]

On Sat, 18 Jul 2020 03:30:39 +0300
Joonas Kylmälä <joonas.kylmala at iki.fi> wrote:

> Hi,
> 
> Denis 'GNUtoo' Carikli:
> > diff --git a/Android.mk b/Android.mk
> > index 6585a31..9da4d2e 100644
> > --- a/Android.mk
> > +++ b/Android.mk
> > @@ -42,7 +42,6 @@ LOCAL_SRC_FILES := \
> >  LOCAL_C_INCLUDES := \
> >  	$(LOCAL_PATH) \
> >  	$(LOCAL_PATH)/include \
> > -	external/libsamsung-ipc/include \
> >  	hardware/libhardware_legacy/include \
> >  	system/core/include
> 
> If I remember correctly there is some way to include the other modules
> headers too in non-hardcoded way, by referencing the module name.

Indeed, this is done by that:
> LOCAL_SHARED_LIBRARIES := [...] libsamsung-ipc

The rest of the LOCAL_C_INCLUDES that are outside LOCAL_PATH will
probably need to be fixed as well later on if we want to include
libsamsung-ril in Replicant 10.

> Anyway this patch looks good to me:
> 
> Acked-by: Joonas Kylmälä <joonas.kylmala at iki.fi>

Thanks, I've now pushed the patch.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20200718/e6cba9c9/attachment.asc>