[Replicant] [vendor_replicant-scripts] [PATCH] graphics: fix user interface

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Wed Jul 22 18:10:42 UTC 2020


The graphics user interface is the following, according to the help:
    Usage: graphics.sh [faster|compatible]
    Examples:
    graphics.sh faster
    |-> Uses Android's libagl
        which is faster
        but some applications
        like icecat won't work
    graphics.sh compatible
    |-> Uses llvmpipe
        which is slower
        but more compatible

However the code is still expecting the "libagl" or "llvmpipe" arguments:
    graphics()
    {
        new_renderer="$1" # libagl || llvmpipe
        [...]
        if [ "${old_renderer}" == "${new_renderer}" ] ; then
	[...]
    }

This fix the code to by passing the libagl and llvmpipe arguments to the
graphics function as it expects, while keeping the same user interface.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
---
 display/renderer/device-files/graphics.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/display/renderer/device-files/graphics.sh b/display/renderer/device-files/graphics.sh
index daf4ee1..1dd4462 100644
--- a/display/renderer/device-files/graphics.sh
+++ b/display/renderer/device-files/graphics.sh
@@ -130,8 +130,10 @@ if [ $# -ne 1 ] ; then
 	usage
 fi
 
-if [ "$1" = "faster" -o "$1" = "compatible" ] ;then
-	graphics "$1"
+if [ "$1" = "faster" ] ; then
+    graphics libagl
+elif [ "$1" = "compatible" ] ;then
+    graphics llvmpipe
 else
 	usage
 fi
-- 
2.27.0



More information about the Replicant mailing list