[Replicant] [libsamsung-ipc] [PATCH 7/7] xmm626_hsic_ack_read: pass the ipc_client struct

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Fri Jul 24 19:47:25 UTC 2020


This enables to use logging inside the callbacks.

At this point the ipc_client struct is already available,
so it is safe to do that.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
---
 samsung-ipc/modems/xmm626/xmm626_hsic.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/samsung-ipc/modems/xmm626/xmm626_hsic.c b/samsung-ipc/modems/xmm626/xmm626_hsic.c
index 16aaf00..0ec7347 100644
--- a/samsung-ipc/modems/xmm626/xmm626_hsic.c
+++ b/samsung-ipc/modems/xmm626/xmm626_hsic.c
@@ -33,7 +33,8 @@
 #include "modems/xmm626/xmm626.h"
 #include "modems/xmm626/xmm626_hsic.h"
 
-int xmm626_hsic_ack_read(int device_fd, unsigned short ack)
+int xmm626_hsic_ack_read(__attribute__((unused)) struct ipc_client *client,
+			  int device_fd, unsigned short ack)
 {
 	struct timeval timeout;
 	fd_set fds;
@@ -215,7 +216,7 @@ int xmm626_hsic_psi_send(struct ipc_client *client, int device_fd,
 	}
 	ipc_client_log(client, "Read PSI CRC ACK");
 
-	rc = xmm626_hsic_ack_read(device_fd, XMM626_HSIC_PSI_ACK);
+	rc = xmm626_hsic_ack_read(client, device_fd, XMM626_HSIC_PSI_ACK);
 	if (rc < 0) {
 		ipc_client_log(client, "Reading PSI ACK failed");
 		goto error;
@@ -257,7 +258,7 @@ int xmm626_hsic_ebl_send(struct ipc_client *client, int device_fd,
 	}
 	ipc_client_log(client, "Wrote EBL size");
 
-	rc = xmm626_hsic_ack_read(device_fd, XMM626_HSIC_EBL_SIZE_ACK);
+	rc = xmm626_hsic_ack_read(client, device_fd, XMM626_HSIC_EBL_SIZE_ACK);
 	if (rc < 0) {
 		ipc_client_log(client, "Reading EBL size ACK failed");
 		goto error;
@@ -291,7 +292,7 @@ int xmm626_hsic_ebl_send(struct ipc_client *client, int device_fd,
 	}
 	ipc_client_log(client, "Wrote EBL CRC (0x%x)", ebl_crc);
 
-	rc = xmm626_hsic_ack_read(device_fd, XMM626_HSIC_EBL_ACK);
+	rc = xmm626_hsic_ack_read(client, device_fd, XMM626_HSIC_EBL_ACK);
 	if (rc < 0) {
 		ipc_client_log(client, "Reading EBL ACK failed");
 		goto error;
-- 
2.27.0



More information about the Replicant mailing list