[Replicant] libsamsung-ipc: Switch to Linux code style

[Denis 'GNUtoo' Carikli]

Hi,

I'm not confident enough to push this patch-set as-is, so I'll most
probably wait as long as possible for it to be reviewed before pushing
it.

The work to do that patchset was very repetitive, which is very prone
to errors: To do that I stared at code that look the same for hours and
hours, fixing code style issues that look the same, one by one.

Since tools were made to test the code, and that the code does
compile, the most important thing for the review is to look for
simple mistakes that changes what the code does in a way that is not
detectable by the compiler.

The patchset isn't supposed to change the way the code behaves, so
any change would probably create an issue that is extremely hard to
debug, as the code conversion is really hard to read.

So for example if the following code was there before:
> if (foo) {
>     do_something();
>     do_something_else();
> }    

and that it was changed to the following code:
> if (foo)
> 	do_something();
> do_something_else();    

Then the compiler will not complain and we do have an issue that
will be extremely hard to spot and debug.

If someone also knows software that can prove that two executable
or C source code files are functionally equivalent at the source
level, it would also be super useful.

Once we have this patch set in, the next step would be to rebase my
modem abstraction and start merging it.

Then we could add support for more devices and/or interfaces:
- Jonathan Bakker (xcracer99) has a patch set for new devices 
- I've also a patchset to add support for the kernel
  interfaces that are currently used in Replicant 9 and 10, but I've no
  visibility yet as if or when we'll merge it as the interface may
  change along the way because the kernel drivers are not upstream yet
  and their interface needs to be cleaned up as well.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20200623/84e8deca/attachment.asc>