[Replicant] Building Replicant 10

[Denis 'GNUtoo' Carikli]

Thanks a lot for all the patches.

> From 895dbbda47660f78057d23d4908db36a9461e503 Mon Sep 17 00:00:00 2001
> From: Tobias Tefke <t.tefke at stud.fh-sm.de>
> Date: Mon, 22 Jun 2020 18:38:35 +0200
> Subject: [PATCH 1/2] i9300: replace vendorsetup.sh by
> COMMON_LUNCH_CHOICES
This patch, and the equivalent patch for the GT-I9305 are good but the
commit messages need to be improved a bit before merging them:
- As this patch targets the i9300 repository, we don't need to repeat
  that in the commit message itself, as people doing a git log on the
  repository will already know it.
  However we still need to know which repository the patches targets
  somehow. To do that I often abuse the subject-prefix or state it in
  the mails somehow. 
  This is an issue that is specific to the way the Replicant project is
  setup as we have a lot of git repositories and the review happens on
  the same mailing list, and it's not always obvious for which
  repository the patches are for.
- We also don't know why you are replacing vendorsetup.sh by 
  COMMON_LUNCH_CHOICES.
- I found why: when building Replicant 10 we can see the following
  (warnings?) in the build log:
  device/samsung/i9300/vendorsetup.sh:17: add_lunch_combo is obsolete.
  Use COMMON_LUNCH_CHOICES in your AndroidProducts.mk instead.
  device/samsung/i9300/vendorsetup.sh:18: add_lunch_combo is obsolete.
  Use COMMON_LUNCH_CHOICES in your AndroidProducts.mk instead.
  It would be a good idea to add that somehow in the commit message
  too. That enables people to understand more the context as why the
  patch is useful.

With all the above fixed, it's would be way easier for someone not
familiar with the issue to understand why this patch is useful.

People looking into the patches could be a reviewer which doesn't
necessarily knows about the issue, or even (future) Replicant
developers that will be wondering which patches we still need to keep
for Replicant 11.

For the other patches, I'll try to review them as soon as possible.

In the meantime it would be great if you can fix the commit messages of
these two patches.

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20200626/4ef1af7d/attachment.asc>