[Replicant] Building Replicant 10

[Denis 'GNUtoo' Carikli]

> From fad350cde930bb78c54d86eab46dc90da4793187 Mon Sep 17 00:00:00 2001
> From: Tobias Tefke <t.tefke at stud.fh-sm.de>
> Date: Mon, 22 Jun 2020 18:43:57 +0200
> Subject: [PATCH 2/2] i9300: properly inherit from LineageOS

[...]
> -$(call inherit-product, vendor/lineage/config/common_phone.mk)
> +$(call inherit-product, vendor/lineage/config/common_full.mk)
As with the two other previous patches that I reviewed, the fix is
good, however we can probably improve the commit message a bit as well:
- As before, you could also drop the i9300 as it's not necessary.
- While looking into this patch I found the issue it fixes: 
  vendor/lineage/config/common_phone.mk simply doesn't exist.
  You need to mention it somehow, otherwise people will not know why the
  change has been made, and could think that you just revert to not
  using _phone as the modem stack isn't ready. For instance:
      Fix call to nonexisting common_phone.mk

      This bug seems to have been caused by a typo, and comes 
      from this commit:
          f1555e9 HACK: Add userspace support for i9300

More background information:
----------------------------
This bug was fixed in this commit "9aa8650 Add support for the
modem"[1], which is from a branch where preliminary work is being done
to add support for the modem[2].

The idea behind using common_full_phone was to have libsamsung-ril
automatically built, even if it wasn't ready, in order to have
compilations tests done automatically as I built test images.

This way I could work on patches that fixed build error with CLANG,
-Werror and the Android build system, while leaving the rest for later,
as I will need to make sure that "the rest" also builds on various
Replicant versions.

[1]https://git.replicant.us/contrib/replicant-9/device_samsung_i9305/commit/?h=replicant-9-i9300&id=9aa865015ea4ae5b0b682f0b73035ac6ed67f558
[2]https://git.replicant.us/contrib/replicant-9/device_samsung_i9305/log/?h=replicant-9-i9300

Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/replicant/attachments/20200626/12a82ea8/attachment.asc>