[Replicant] [vendor_replicant] [PATCH v4 1/3] build.sh: usage: fix non-optional argument

Denis 'GNUtoo' Carikli GNUtoo at cyberdimension.org
Thu Oct 8 15:19:35 UTC 2020


Without that fix the help looks like that:
    ./build.sh [espresso3g|espressowifi|i9100|i9300|i9305|maguro|...]
The issue here is that square brackets are commonly used to indicate
optional arguments, but here an argument is required.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at cyberdimension.org>
---
 build.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.sh b/build.sh
index e9fa57f6..645e5472 100755
--- a/build.sh
+++ b/build.sh
@@ -30,11 +30,11 @@ supported_machines=" \
 
 usage()
 {
-	printf "%s [" "$0"
+	printf "%s <" "$0"
 	for machine in ${supported_machines} ; do
 		printf "${machine}|"
 	done
-	printf "\b]\n"
+	printf "\b>\n"
 	printf "%s all # build all machines\n" "$0"
 	exit 1
 }
-- 
2.28.0



More information about the Replicant mailing list